allowed compilation without defaullt features #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mallets
requested changes
Nov 28, 2023
There was a problem hiding this comment.
Please add the explanation in the README on how to pass additional compilation features. I suggest to keep the same parameters as in the README to invoke cmake. E.g.:
cmake ../zenoh-c -DZENOHC_CARGO_FLAGS="--no-default-features;--features=zenoh/transport_tcp,zenoh/transport_udp"
Mallets
reviewed
Nov 28, 2023
Done |
This was referenced Nov 28, 2023
Mallets
approved these changes
Nov 29, 2023
sashacmc
pushed a commit
to ZettaScaleLabs/zenoh-c
that referenced
this pull request
Nov 29, 2023
Co-authored-by: Luca Cominardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's possible to build library with some protocols disabled
This update works together with PR eclipse-zenoh/zenoh#604, link to branch "feature_cleanup2" should be replaced to "master" before commit